sparkle-project / Sparkle

A software update framework for macOS
https://sparkle-project.org
Other
7.37k stars 1.05k forks source link

Fix KVO usage for updaterController.updater.* #2404

Closed zorgiepoo closed 1 year ago

zorgiepoo commented 1 year ago

KVO was not set up properly when trying to retrieve the updater from the updater controller, especially when the updater controller hasn't been fully initialized yet.

Fixes issues brought in discussion #2403

Misc Checklist

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

Tested with a test app that references updater.canCheckForUpdates on an SPUStandardUpdaterController instance.

macOS version tested: 13.4.1 (22F82)