Also fixes some logic for notifying the updater delegate when the app is about to install as before there may have been a race in the app being quit before the notification was fired (although maybe this was rare).
[ ] My change requires changes to generate_appcast, generate_keys, or sign_update
Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.
Testing
I tested and verified my change by using one or multiple of these methods:
[x] Sparkle Test App
[ ] Unit Tests
[ ] My own app
[x] Other (please specify)
Tested a background test app using Sparkle which on macOS 14 correctly
Activates permission prompt window to front near launch
Activates update checking window to front near launch
Activates update checking window when clicking user notification
Activates update checking window from status menu bar item
Tested a "slow update" (on a USB mount) which shows update progress window to front after app has been terminated.
Tested nothing breaks in macOS 13 as well.
Tested update installation delegate is still fired and not fired multiple times, both from regular app and from sparkle-cli, both when app is still running and already terminated.
macOS version tested:
14.0 Beta (23A5301g)
13.5 (22G74)
Fixes #2398
Also fixes some logic for notifying the updater delegate when the app is about to install as before there may have been a race in the app being quit before the notification was fired (although maybe this was rare).
Misc Checklist
Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.
Testing
I tested and verified my change by using one or multiple of these methods:
Tested a background test app using Sparkle which on macOS 14 correctly
Tested a "slow update" (on a USB mount) which shows update progress window to front after app has been terminated. Tested nothing breaks in macOS 13 as well.
Tested update installation delegate is still fired and not fired multiple times, both from regular app and from sparkle-cli, both when app is still running and already terminated.
macOS version tested: 14.0 Beta (23A5301g) 13.5 (22G74)