search

sparkle-project / Sparkle

A software update framework for macOS
https://sparkle-project.org
Other
7.37k stars 1.05k forks source link

Corrected hyphenation for 'already current' status message #2422

Closed domneill closed 1 year ago

domneill commented 1 year ago

(See https://github.com/sparkle-project/Sparkle/pull/1654)

Noticed from some clients using the latest Sparkle release that this appears to have regressed. (Likely because Sparkle.strings was removed from en.lproj/ at some point.)

This brings the fix from #1654 into the base loc file in the absence of a dedicated English one.

zorgiepoo commented 1 year ago

Oops, thanks. I actually want to update all the keys though because we have a compile time option to not include any of the localizations. In that case, it will use the key, which is apparently incorrect.

zorgiepoo commented 1 year ago

It regressed from https://github.com/sparkle-project/Sparkle/pull/2113 which was too subtle for me to pick up and notice while reviewing that change (it may have had some autogeneration too).

We should definitely update all the keys / usages of this so it won't happen again.

zorgiepoo commented 1 year ago

Handling in #2425.