sparkle-project / Sparkle

A software update framework for macOS
https://sparkle-project.org
Other
7.37k stars 1.05k forks source link

Fix make release not building distribution successfully #2430

Closed zorgiepoo closed 1 year ago

zorgiepoo commented 1 year ago

For some reason, the default BUILDDIR that was set was problematic. We are now defaulting BUILDDIR inside of ./build which resolves this issue. This also means by default, builds are not placed inside of system temp directories anymore.

I do not know when this stopped working or why.

Misc Checklist

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

Tested make release built successfully on my machine.

macOS version tested: 13.5 (22G74) 14.0 (23A5328b)