sparkle-project / Sparkle

A software update framework for macOS
https://sparkle-project.org
Other
7.37k stars 1.05k forks source link

Perform Gatekeeper scan and still use new temp directory for installs #2433

Closed zorgiepoo closed 1 year ago

zorgiepoo commented 1 year ago

This restores using a new temporary directory before swapping the app update (when the bundles are on the same volume). It turns out it is still a good idea to have this. This also seems to allow doing the gatekeeper scan without any issues on macOS Sonoma.

Misc Checklist

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

Tested updating notarized app Tested updating unsigned app Tested updating app on different volume (USB drive)

macOS version tested: 14.0 Beta (23A5337a)