This only applies when multiple XML nodes are present with the same name. E.g. multiple description or releaseNoteLink elements with different xml:lang's specified.
Also generate a warning if a language has to be interpreted implicitly when there is no xml:lang explicitly specified and there are multiple node items.
[ ] My change requires changes to generate_appcast, generate_keys, or sign_update
Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.
Testing
I tested and verified my change by using one or multiple of these methods:
[x] Sparkle Test App
[x] Unit Tests
[ ] My own app
[ ] Other (please specify)
Tested two description elements in test app with one element not set, and other set to es. Changed system language to English and Spanish.
Tested two description elements in test app with one element set to en, and other set to es. Changed system language to English and Spanish.
This only applies when multiple XML nodes are present with the same name. E.g. multiple description or releaseNoteLink elements with different xml:lang's specified.
Also generate a warning if a language has to be interpreted implicitly when there is no xml:lang explicitly specified and there are multiple node items.
Related: #2437
Misc Checklist
Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.
Testing
I tested and verified my change by using one or multiple of these methods:
Tested two description elements in test app with one element not set, and other set to
es. Changed system language to English and Spanish. Tested two description elements in test app with one element set toen, and other set toes. Changed system language to English and Spanish.macOS version tested: 14.0 (23A344)