Under rare circumstances, if Autoupdate receives SIGTERM (like during system shutdown) while the installer queue is installing an update this could cause potential corruption.
[ ] My change requires changes to generate_appcast, generate_keys, or sign_update
Testing
I tested and verified my change by using one or multiple of these methods:
[x] Sparkle Test App
[ ] Unit Tests
[ ] My own app
[ ] Other (please specify)
Cannot reproduce actual corruption issue without inserting sleep() calls at specific points + sending a quit event to Autoupdate as the timing window is hard to target / rare. The change here is removing cleanup code that was not necessary (because old items get cleared out the next time an update is installed).
Tested Autoupdate can still be terminated gracefully via SIGTERM.
Under rare circumstances, if Autoupdate receives SIGTERM (like during system shutdown) while the installer queue is installing an update this could cause potential corruption.
Fixes #2478
Misc Checklist
Testing
I tested and verified my change by using one or multiple of these methods:
Cannot reproduce actual corruption issue without inserting sleep() calls at specific points + sending a quit event to Autoupdate as the timing window is hard to target / rare. The change here is removing cleanup code that was not necessary (because old items get cleared out the next time an update is installed).
Tested Autoupdate can still be terminated gracefully via SIGTERM.
macOS version tested: 14.1.2 (23B92)