Update Korean localization

zooxop commented 6 months ago

Hello!

First of all, I would like to thank the Sparkle project for the amazing feature support. It made it very easy for me to implement the ability to update my app.

Anyway, while applying Sparkle to my app, I noticed that some Korean localization was missing. So, I added the missing Korean localization keys and fixed some other expressions that I personally felt were unnatural.

Misc Checklist

[ ] My change requires a documentation update on Sparkle's website repository
[ ] My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

[x] Sparkle Test App
[ ] Unit Tests
[ ] My own app
[ ] Other (please specify)

What I tested :

<sparkle:criticalUpdate>
<sparkle:minimumSystemVersion>
<sparkle:maximumSystemVersion>

macOS version tested: 14.1

zorgiepoo commented 6 months ago

Had some minor comments that doesn't really affect anything. Looks good to me. Thanks!

zooxop commented 6 months ago

Had some minor comments that doesn't really affect anything. Looks good to me. Thanks!

To avoid mistakes, I copied and pasted the following code base for the work, and I synchronized the comments in the process.

https://github.com/sparkle-project/Sparkle/blob/24f0f3952d4cbd7fc89a72ff70cece926538673c/Sparkle/en.lproj/SUUpdatePermissionPrompt.strings#L8-L12

I didn't sufficiently consider the possibility that this modification might be wrong!

It's fortunate that it doesn't matter much. Thank you for your thorough review!

sparkle-project / Sparkle

Update Korean localization #2504

Misc Checklist

Testing