sparkle-project / Sparkle

A software update framework for macOS
https://sparkle-project.org
Other
7.34k stars 1.04k forks source link

Perform Gatekeeper scan to pre-warm app launch #2505

Closed zorgiepoo closed 6 months ago

zorgiepoo commented 6 months ago

This avoids users seeing a "Verifying..." Dialog when the installed update is (re-)launched.

This scan is only done for macOS 14.4+ onwards (gktool was introduced in macOS 14.0 but had issues).

Also this scan is only done if Autoupdate's team identifier matches the new update's team identifier. Otherwise the OS may think Autoupdate is modifying a bundle that it shouldn't be permitted to.

Fixes #2491

Misc Checklist

Testing

I tested and verified my change by using one or multiple of these methods:

Tested updating my own notarized app and saw gktool run without issue when Autoupdate & app bundle to be updated are signed with same Team Identifier. Tested gktool is not ran when Team Identifier differs or system is running an OS before 14.4.

macOS version tested: 14.4 Beta (23E5196e) 14.3 (23D56) (skipped)