Fallback in case SULocalizedStringFromTableInBundle() fails - Githubissues

sparkle-project / Sparkle

A software update framework for macOS

https://sparkle-project.org

Other

7.41k stars 1.05k forks source link

Fallback in case SULocalizedStringFromTableInBundle() fails #2533

Closed zorgiepoo closed 6 months ago

zorgiepoo commented 6 months ago

SULocalizedStringFromTableInBundle() should only fail in the abnormal situation where the app bundle may have been moved while it was running. Technically the app is running in an unsupported state but I suppose we can guard against it here.

This is a continuation of #2527 and fixes https://github.com/sparkle-project/Sparkle/issues/2524

Misc Checklist

[ ] My change requires a documentation update on Sparkle's website repository
[ ] My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

[x] Sparkle Test App
[ ] Unit Tests
[ ] My own app
[ ] Other (please specify)

Tested test app works and works with another language still.

macOS version tested: 14.4 (23E214)