sparkle-project / Sparkle

A software update framework for macOS
https://sparkle-project.org
Other
7.28k stars 1.04k forks source link

Update hebrew locale #2573

Closed ShlomoCode closed 1 month ago

ShlomoCode commented 1 month ago

I am a native speaker

Fixes # (issue)

Misc Checklist

Testing

I tested and verified my change by using one or multiple of these methods:

(Describe all the cases that were tested)

macOS version tested: 14.5

zorgiepoo commented 1 month ago

GitHub won't allow me to merge this because it is still a draft.

ShlomoCode commented 1 month ago

Yes, I made a few quick fixes, in the next few days I'll finish it and get it out of draft mode

ShlomoCode commented 1 month ago

@zorgiepoo It's ready to merge

zorgiepoo commented 1 month ago

The Hebrew localization is not currently enabled in SUUpdatePermissionPrompt.xib. It can be enabled in Xcode's File inspector for that file.

ShlomoCode commented 1 month ago

I have activated the SUUpdatePermissionPrompt file now

zorgiepoo commented 1 month ago

Thank you. I'll merge after the CI automation is done verifying the changes.

(One note: it's easier for me to review/track changes if you don't force push commits on the pull request branch. Also typically people create a separate branch when merging changes so they can keep their 2.x branch in sync. Edit: never mind, I see GitHub provides me of a way of comparing different revisions still. Oh well).

ShlomoCode commented 1 month ago

Would you like to wait for me to add RLM tags or should we do it in a new PR?

zorgiepoo commented 1 month ago

Let's separate it and wait until this one merges.