search

sparkle-project / Sparkle

A software update framework for macOS
https://sparkle-project.org
Other
7.28k stars 1.04k forks source link

Release note style doesn't update on light/dark appearance change #2581

Closed kdrag0n closed 1 month ago

kdrag0n commented 1 month ago

Summary

A light/dark release notes stylesheet is selected when the updater windows is opened, but not updated when the system light/dark theme later changes (e.g. due to sunset/sunrise-based theming): (https://github.com/orbstack/orbstack/issues/1264)

image

Possible Fix

Update stylesheet on viewDidChangeEffectiveAppearance.

Version

2.4.2

zorgiepoo commented 1 month ago

Please try the latest release (2.6.3 currently). See also #2542.

kdrag0n commented 1 month ago

Ah sorry, I did a quick search for viewDidChangeEffectiveAppearance and didn't find anything. v2.6.3 works fine.