search

sparkle-project / Sparkle

A software update framework for macOS
https://sparkle-project.org
Other
7.37k stars 1.05k forks source link

System font greater than 13pt for SUStatus.xib #2613

Closed ChrisW698 closed 2 weeks ago

ChrisW698 commented 3 weeks ago

We’ve received a number of user reports concerning the Sparkle update progress dialog, where the ‘x MB of x MB’ text appears larger than the System Regular 13 font size, causing the download progress count to be truncated. As shown in the attached screenshot, it seems that users are increasing the system-wide font size beyond System Regular 13 using TinkerTool, which is leading to this issue.

Sparkle-TechToolPro
zorgiepoo commented 3 weeks ago

This is an annoying Autolayout issue to enforce that the text field makes the window grow horizontally instead of wrapping or truncating in SUStatus.xib (SUStatusController also sets the font for the text field to be a monospaced digit system font with system font size).

After changing the system font you can set a breakpoint in -[SPUStandardUserDriver showDownloadDidStartExtractingUpdate:] to see how the status window looks like.

Note changing the system font with a non-system tool like TinkerTool is not a super supported/common path. However increasing the text field font size should technically work. Maybe @DivineDominion would have an idea on this. I don't want to subclass NSTextField.

zorgiepoo commented 3 weeks ago

Actually have a fix in #2614

ChrisW698 commented 3 weeks ago

Thank you and greatly appreciated.

DivineDominion commented 2 weeks ago

@zorgiepoo I'm not that fast :D Happy that you found a solution already!