search

sparkleformation / sparkle_formation

Ruby orchestration templating library built with unicorns and rainbows
http://www.sparkleformation.io
Apache License 2.0
222 stars 47 forks source link

warning: constant ::Fixnum is deprecated... #232

Closed fforloff closed 7 years ago

fforloff commented 7 years ago

When using sparkle_formation gem version 3.0.24 with Ruby 2.4.1 I am getting the following warnings: vint@belka ~/code/sfn-lab » sfn print --file ecs_infra /usr/lib/ruby/gems/2.4.0/gems/sparkle_formation-3.0.24/lib/sparkle_formation/sparkle.rb:114: warning: constant ::Fixnum is deprecated /usr/lib/ruby/gems/2.4.0/gems/sparkle_formation-3.0.24/lib/sparkle_formation/sparkle.rb:114: warning: constant ::Bignum is deprecated /usr/lib/ruby/gems/2.4.0/gems/sparkle_formation-3.0.24/lib/sparkle_formation/sparkle.rb:114: warning: constant ::NIL is deprecated /usr/lib/ruby/gems/2.4.0/gems/sparkle_formation-3.0.24/lib/sparkle_formation/sparkle.rb:114: warning: constant ::TRUE is deprecated /usr/lib/ruby/gems/2.4.0/gems/sparkle_formation-3.0.24/lib/sparkle_formation/sparkle.rb:114: warning: constant ::FALSE is deprecated

Please advise.

jimcroft commented 7 years ago

Safe to ignore those warnings. The fix has already been merged into the develop branch #228. You can either use that branch or sit tight and wait for the next release.

fforloff commented 7 years ago

No worries. Thanks Jim. BTW, I took liberty to create a whalebrew package for the sparkleformation - https://github.com/whalebrew/whalebrew-packages/pull/51. Will update to alpine:latest once you nave the new release.