search

sparklemotion / mechanize

Mechanize is a ruby library that makes automated web interaction easy.
https://www.rubydoc.info/gems/mechanize/
MIT License
4.39k stars 473 forks source link

fix: stop force_encoding the page body #610

Closed flavorjones closed 1 year ago

flavorjones commented 1 year ago

which allows us to handle frozen strings

This is an alternative solution to the problem described in #609

flavorjones commented 1 year ago

@tenderlove Do you recall why we started calling force_encoding on the body string in 3d4535f9? It doesn't seem like it's needed.

tenderlove commented 1 year ago

I don't remember, but I agree it doesn't seem necessary

flavorjones commented 1 year ago

I've cut v2.9.0 with this change.