search

sparklemotion / mechanize

Mechanize is a ruby library that makes automated web interaction easy.
https://www.rubydoc.info/gems/mechanize/
MIT License
4.39k stars 473 forks source link

Add nkf as dependency for Ruby 3.4 support #633

Closed johnvuko closed 7 months ago

johnvuko commented 7 months ago

Hello, Since Ruby 3.3 there is now a warning:

gems/mechanize-2.9.1/lib/mechanize/util.rb:3: warning: nkf was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add nkf to your Gemfile or gemspec. Also contact author of mechanize-2.9.1 to add nkf into its gemspec

flavorjones commented 7 months ago

Thank you for opening this. Please follow along upstream in https://github.com/ruby/nkf/issues/13. Once that's resolved I'll fix it in mechanize.

flavorjones commented 7 months ago

Seems like we'll have a jruby gem for nkf shortly, see https://github.com/ruby/nkf/pull/15

Once that's released, I will update this gem's dependencies.

flavorjones commented 7 months ago

v2.10.0 is out with this fixed.