search

sparklemotion / nokogiri.org

Documentation site for Nokogiri (a ruby library)
https://nokogiri.org/
MIT License
45 stars 24 forks source link

Add Alpine Linux (Docker) instructions. #23

Closed kylev closed 5 years ago

flavorjones commented 5 years ago

Hi! Thanks for taking the time to write up this content and submit it as a PR!

Can I ask, to improve clarity, that you consider refactoring this section to be two, more focused sections? Currently it addresses two things: how to get up and running on a minimal Alpine image; and how to get a minimal docker installation.

I think I'd prefer that this be two separate sections:

  1. Alpine - how to install the required libraries if they're not already present
  2. Building a minimal docker image using the clever add/remove hack (which I've not seen before! tricky!), and using the Alpine packages commands as a specific example of how to do it

An alternative might be to make the "minimal docker image" a subsection in the Alpine section; that'd probably be fine, too.

Thanks again!

kylev commented 5 years ago

Host about this: I split it into the "impatient guide" under OS installation, then added a section on --use-system-libraries. The optimization tricks fit better as a part of the latter.

flavorjones commented 5 years ago

Awesome! Thank you for this, merging and deploying now.

flavorjones commented 5 years ago

Deployed to nokogiri.org! Thanks again. :heart: