sparkletown / sparkle

Building an open, community-owned hyperverse town
GNU Affero General Public License v3.0
33 stars 30 forks source link

chat: emoji picker #1395

Closed yarikoptic closed 3 years ago

yarikoptic commented 3 years ago

A chaser for #1393 (a "fix" proposed in #1394) : I wonder how much work would adding emoji picker such as e.g. https://github.com/missive/emoji-mart would be?

0xdevalias commented 3 years ago

@yarikoptic Interesting you should raise this, as it's something I had looked into a bit and included on part of our backlog. I hadn't gone deep on making all of the decisions/explorations around this yet, but I'll include relevant snippets below (note: you won't be able to see any of the 'internal' issues that are linked)

See also my notes in https://github.com/sparkletown/sparkle/issues/1393#issuecomment-841595066 that refer to https://github.com/sparkletown/sparkle/issues/1395#issuecomment-841594823


  1. Emoji support

Originally posted by @jess-sparkles in https://github.com/sparkletown/internal-sparkle-issues/issues/484#issuecomment-796006117


Some resources I stumbled across the other day, capturing here for posterity:

Originally posted by @0xdevalias in https://github.com/sparkletown/internal-sparkle-issues/issues/188#issuecomment-817416820

0xdevalias commented 3 years ago

[OOS] While it's OOS for this PR, in future we could likely use this same lib/pattern to enhance our existing 'reactions' feature as well. Currently it just uses hardcoded emoji:

Some of the related files:

We also have a backlog issue (scheduled to be worked on soon, after a couple of higher priority features) to clean up all of the 'send reaction' buttons/etc across the codebase into a single canonical component + logic in a hook, etc (currently each venue template has it's own duplicated code for rendering the 'reaction buttons' in places like the Jazz Bar, Auditorium (Audience), etc:

Originally posted by @0xdevalias in https://github.com/sparkletown/sparkle/issues/1394#issuecomment-841598849

0xdevalias commented 3 years ago

@0xdevalias @soichih added emoji-mart picker here to see how it all would look. Wdyt?

Originally posted by @yarikoptic in https://github.com/sparkletown/sparkle/issues/1383#issuecomment-845900638


while testing with env/ohbm and bunch of other perspective PRs merged, https://github.com/yarikoptic/sparkle/pull/new/my-ohbm 915857eb518a529ac8b00ce26c9fa5ea54ce8cd4 I noticed that the text in emoji-mart selector (which has white background -- easy to change to black @soichih ??) was white.

_Originally posted by @yarikoptic in https://github.com/sparkletown/sparkle/pull/1383#discussion_r640088872_