sparkplug / momoapi-node

MTN MoMo API Client for Node
https://www.npmjs.com/package/mtn-momo
MIT License
59 stars 47 forks source link

feat: remittances #72

Open luigimorel opened 2 years ago

luigimorel commented 2 years ago

Add the remittance operation to SDK.

Fixes #14.

Please test and let me there's anything I'm missing.

luigimorel commented 2 years ago

yes i did. referenceId is not optional.


Luigi Morel.

Software Engineer

Tel: +256 704 916 696 (WhatsApp only)

On Wed, Apr 20, 2022, 14:31 Ernest Okot @.***> wrote:

@.**** commented on this pull request.

In src/errors.ts https://github.com/sparkplug/momoapi-node/pull/72#discussion_r854027812:

@@ -171,7 +172,7 @@ export function getError(code?: FailureReason, message?: string) { return new UnspecifiedError(message); }

-export function getTransactionError(transaction: Payment | Transfer) { +export function getTransactionError(transaction: Payment | Transfer | Remit) { const error: MtnMoMoError = getError(transaction.reason as FailureReason);

Did you check in the docs?

— Reply to this email directly, view it on GitHub https://github.com/sparkplug/momoapi-node/pull/72#discussion_r854027812, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALR3BBP3A5T72BC7VJS35SDVF7TITANCNFSM5TPJSPOA . You are receiving this because you authored the thread.Message ID: @.***>