search

sparks-baird / CrabNet

Predict materials properties using only the composition information!
https://crabnet.readthedocs.io/
MIT License
12 stars 5 forks source link

Fictitious validation MAE (just same as training) when only training data is supplied #3

Closed sgbaird closed 2 years ago

sgbaird commented 2 years ago

https://github.com/sgbaird/CrabNet/blob/master/crabnet/train_crabnet.py

sgbaird commented 2 years ago

See https://github.com/anthony-wang/CrabNet/issues/15#issuecomment-1031412555. I.e. I should change it so that it actually uses the validation data.

sgbaird commented 2 years ago

Should be resolved (i.e. if only train supplied, internally splits into train/val)