search

sparksp / elm-review-action

GitHub action using elm-review to check code quality
MIT License
12 stars 1 forks source link

Consider adding elm-review warnings as comments/code changes to PR #29

Open kutyel opened 3 years ago

kutyel commented 3 years ago

The idea is to have something like Hintman but for Elm + GH Actions pipeline 💪🏻 What are your thoughts about it? 😉

jfmengels commented 3 years ago

:wave:

I'm confused, what is the difference between what you're proposing and what elm-review-action currently does? :thinking:

kutyel commented 3 years ago

Basically comments in the PR and maybe even code refactors in the PR section in Github? From what I have tried in this action it just displays nicer errors in the Actions tab... I couldn't even see the annotations in the code changes 🤔

sparksp commented 3 years ago

I think when I first authored this action the suggestions API wasn't available yet, and annotations were all we had. I'm concerned that you're not seeing the annotations - that possibly means something has changed for the worse in GitHub land, but if I'm able to create suggestions now instead of annotations then that will be nicer all round.

sparksp commented 3 months ago

It looks like the GitHub actions tooling has now caught up and this might be a possibility. Unfortunately I do not have any time to put to this at the moment.