search

sparksuite / codemirror-spell-checker

Dead-simple spell checking in CodeMirror
http://sparksuite.github.io/codemirror-spell-checker/
MIT License
83 stars 52 forks source link

Added multilanguage support #39

Open eutampieri opened 6 years ago

eutampieri commented 6 years ago

This pull request aims to address:

eutampieri commented 6 years ago

Sorry but I don't see your message on github PR. Anyway, I think the feature is fully implemented now. Thank you, Eugenio Il Mer, 7 Febbraio 2018 3:27 pm, Nicklas Kevin Frank ha scritto:

@eutampieri Want someone to look at this? This seems like a very nice feature to have.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/sparksuite/codemirror-spell-checker/pull/39#issuecomment-363785278

Eugenio Tampieri

Frozire commented 6 years ago

@eutampieri Hmm, I don't see it either, oh well thanks a lot!

We pulled it in with some other business-specific changes, and it seems to be working great.

augustoteixeira commented 6 years ago

I am very much interested in this feature. How is the PR going?

If you have no plans to incorporate this to the standard bower installation anytime soon, could you give me a hint on how I could compile this branch from source? I tried bower install with no success.

Right now I can only install the extension through the instructions in README.md.

Thanks

eutampieri commented 6 years ago

@gutosurrex I don't know what the development team has decided, I'm not part of this project anyway. I can't answer to the second question either because I've planned to use as a standalone JS file (https://github.com/ETSoftware/codemirror-spell-checker/blob/8df1c17873c93a5e6df76a7a59b880862172bc55/src/js/spell-checker.js)

TristanPouliquen commented 5 years ago

Hey,

is this still considered for validation anyday soon ? Would be a great addition to the library !

eutampieri commented 5 years ago

Indeed

Eugenio Tampieri

Il giorno 6 apr 2019, alle ore 17:04, Tristan Pouliquen notifications@github.com ha scritto:

Hey,

is this still considered for validation anyday soon ? Would be a great addition to the library !

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

TristanPouliquen commented 5 years ago

@eutampieri I took the liberty to start from your work to update it a little and I opened an issue on this topic on EasyMDE which is a popular and active fork of SimpleMDE and uses this feature : https://github.com/Ionaru/easy-markdown-editor/issues/78

eutampieri commented 5 years ago

You did the right thing!

Eugenio Tampieri

Il giorno 8 apr 2019, alle ore 09:41, Tristan Pouliquen notifications@github.com ha scritto:

@eutampieri I took the liberty to start from your work to update it a little and I opened an issue on this topic on EasyMDE which is a popular and active fork of SimpleMDE and uses this feature : Ionaru/easy-markdown-editor#78

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

A-312 commented 4 years ago

ping @kirrok, @WesCossick

A-312 commented 4 years ago

This PR seem ready after a rebase.

@eutampieri Can you rebase ?

eutampieri commented 4 years ago

I'll have a look on Monday (hopefully)

eutampieri commented 4 years ago

It seems to me that only the minified file is conflicting…

A-312 commented 4 years ago
  1. Valid the conflict.
  2. Regenarate the minfield.
  3. Commit :)