search

sparksuite / react-accessible-dropdown-menu-hook

A simple Hook for creating fully accessible dropdown menus in React
http://sparksuite.github.io/react-accessible-dropdown-menu-hook
MIT License
112 stars 26 forks source link

Improve testing coverage #258

Closed WesCossick closed 3 years ago

WesCossick commented 3 years ago

This PR aims to improve the coverage percentage as much as possible. It looks like it's still only possible to test the clicking outside of the menu in a real, headless browser, but that's the only part that's uncovered by Jest's test suite.

codecov[bot] commented 3 years ago

Codecov Report

Merging #258 (617d58e) into master (9a28aad) will increase coverage by 6.97%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   84.88%   91.86%   +6.97%     
==========================================
  Files           1        1              
  Lines          86       86              
  Branches       24       24              
==========================================
+ Hits           73       79       +6     
+ Misses         13        7       -6
Impacted Files Coverage Δ
src/use-dropdown-menu.ts 91.86% <0.00%> (+6.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a28aad...617d58e. Read the comment docs.