Support for Space along with Enter key in itemListener?

sparksuite / react-accessible-dropdown-menu-hook

A simple Hook for creating fully accessible dropdown menus in React

http://sparksuite.github.io/react-accessible-dropdown-menu-hook

MIT License

112 stars 26 forks source link

Support for Space along with Enter key in itemListener? #269

Closed prios-chris-abbato closed 3 years ago

prios-chris-abbato commented 3 years ago

Hi there, is there any reason that Space was not supported in keyboard accessibility similar to Enter? Is this something you are considering adding?

Thanks!

corymharper commented 3 years ago

Hi @prios-chris-abbato thanks for opening the issue and asking! The keyboard controls we implemented were based on this list of keyboard interactions: https://www.w3.org/TR/wai-aria-practices/#keyboard-interaction-12. At the time of implementation we decided to only implement those keyboard controls marks as "Required" for the initial release. I am not at all opposed to implementing other keyboard controls described in that documentation, we will definitely consider adding it.

corymharper commented 3 years ago

We will probably get to this pretty quickly, but if you would like to see a change like this more immediately and have the time, I definitely encourage you to make a contribution!