sparksuite / react-accessible-dropdown-menu-hook

A simple Hook for creating fully accessible dropdown menus in React

http://sparksuite.github.io/react-accessible-dropdown-menu-hook

MIT License

112 stars 26 forks source link

Resolve the same version of @types/react for all dependencies in test project #271

Closed corymharper closed 3 years ago

corymharper commented 3 years ago

This pull request adds a resolution object to the package.json to ensure anything that depends on @types/react resolves the same version.

Closes #270

codecov[bot] commented 3 years ago

Codecov Report

Merging #271 (3bed20a) into master (d460aac) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files           1        1           
  Lines          85       85           
  Branches       24       24           
=======================================
  Hits           78       78           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d460aac...3bed20a. Read the comment docs.

WesCossick commented 3 years ago

If this is happening for @types/react would it be happening for all the other link:../.. dependencies in this package.json file?

corymharper commented 3 years ago

If this is happening for @types/react would it be happening for all the other link:../.. dependencies in this package.json file?

Not necessarily, this happens for @types/react because @types/react-dom lists it as a dependency and tries to resolve it's own version.

WesCossick commented 3 years ago

Would it hurt to add all the other packages to the resolutions, though, just in case there are ever conflicting versions for dependencies that depend on one another?

corymharper commented 3 years ago

Would it hurt to add all the other packages to the resolutions, though, just in case there are ever conflicting versions for dependencies that depend on one another?

I don't think it would hurt anything, I can make that change.