search

sparksuite / react-accessible-dropdown-menu-hook

A simple Hook for creating fully accessible dropdown menus in React
http://sparksuite.github.io/react-accessible-dropdown-menu-hook
MIT License
112 stars 26 forks source link

Reduce variables in examples #284

Closed WesCossick closed 3 years ago

WesCossick commented 3 years ago

Closes #283.

This PR removes setIsOpen from a couple of simple code examples, since it's not necessary for basic usage. It also removes variable instantiation from the "Options" page's code example, since the example really only needs to focus on the options (and not the return value).

codecov[bot] commented 3 years ago

Codecov Report

Merging #284 (c8ae0d6) into master (9401baa) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   90.72%   90.72%           
=======================================
  Files           1        1           
  Lines          97       97           
  Branches       31       31           
=======================================
  Hits           88       88           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9401baa...c8ae0d6. Read the comment docs.