search

sparkutils / quality

A Quality Spark DQ Library
https://sparkutils.github.io/quality/
Apache License 2.0
4 stars 2 forks source link

notatoken off by one, allow breaking to be specified #54

Closed chris-twiner closed 8 months ago

chris-twiner commented 9 months ago

with a token "" and "I am atomic" notAToken will produce "I am atomic", so the first one is captured but not the second. A final iteration is needed so <= must be used in the docsparser

breakingTokens should be pulled out to a default param allowing specific breaking tokens to be added. E.g. a default breaking Token of ("`","and") it'd be useful to allow quotes to include and so you'd want:

 lazy val quotedIdentifier = notAToken(Seq("`"))
chris-twiner commented 9 months ago

also provide overridden parseDebug which provides the actual parse return for debugging.