search

sparky8512 / starlink-grpc-tools

Random scripts and other bits for interacting with the SpaceX Starlink user terminal hardware
The Unlicense
482 stars 64 forks source link

Respect the environment #98

Closed dotysan closed 1 month ago

dotysan commented 1 month ago

Just some minor nits for those of us who use Python in a virtual environment rather than system-wide.

dotysan commented 1 month ago

This was cherry-picked from some other changes I made to improve running in a venv and with Python 3.12. https://github.com/sparky8512/starlink-grpc-tools/compare/main...dotysan:starlink-grpc-tools:dotysan Not regression tested.

sparky8512 commented 1 month ago

To be honest, I was thinking of removing those shebang lines. I always use venv myself, but since I do most of my testing in a Windows environment, I don't ever execute the scripts directly.

But if you're proposing this change, then I guess at least 1 person is using them, so they can stay.