SteinerPascal
commented
1 year ago Hi yes okay well i would not adivse on the customizing CSS solution. Because this would mean that people have to adapt the css within /node_modules folder. Now this folder should always remain idempotent regarding installs. Because as soon as Sparnatural would update, npm would pull the new version and overwrite the sparnatural folder within the node_modules ( and therefore the css as well). Additionally, the node_modules/ folder gets often deleted when having build or dependency issues. So if somebody deletes the node_modules/ folder and then does a reinstall with npm install would cause the css to be changed back again.
Edit:
Also if somebody uses sparnatural in its project and adapts the css within the node_modules will only work if this person also pushes its node_modules folder on his GitHub project (which obviously nobody does). otherwise somebody will download the project using sparnatual and do a npm install and npm will pull the sparnatural on the registry which has default css styling.
I would handle it incode i think... Maybe something like a single configuration property being a styling object. This could look like this in a website integration:
let style = {
backgroundBaseColor: 'blabla',
arrowColor: 'hexvalue',
...
}Please note: I'm not an expert on these things so maybe you get a second opinion on this...
tfrancart
As the CSS is compiled and minified at compile-time, I don't think someone using this can adapt. We have requests to be able to customize the CSS, maybe only the values that are in the "themes.scss" file. Maybe that file could be left external to the compiled CSS, so that users can adapt it (without having to recompile the whole thing) ?
See also #410 to provide 2 or 3 default color themes, which could be a temporary workaround
@SteinerPascal do you have an idea on this ?
In relation to this, I would find it nice if the "backgroundColor" config property be also part of the CSS theme, and not part of the settings passed to the Javascript. This would be more consistent.