search

sparna-git / shacl-play

SHACL validation UI, SHACL documentation generator, SHACL generator from RDF.
http://shacl-play.sparna.fr
GNU Lesser General Public License v3.0
24 stars 15 forks source link

Click on UML diagram does not navigate to corresponding section of Docs #66

Closed nikokaoja closed 1 year ago

nikokaoja commented 1 year ago

In previous versions of shacl-play (0.6), when UML diagram is generated as a part of docs it was possible to navigate to sections of docs by clicking on objects on UML diagram.

In the latest version (0.6.1), when clicking on UML diagram, the page navigates to part of the diagram instead of the corresponding doc section.

tfrancart commented 1 year ago

I think the update of plantuml in this new version now inserts IDs inside the SVG diagram with exactly the same name as our section anchors...

nikokaoja commented 1 year ago

What would be solution? To go down to older version of plantuml dependency ?

or to make modification to SVG IDs ?

nikokaoja commented 1 year ago

Just to confirm that after doing regex update on SVG IDs clicking on UML diagrams works as before:

regex expression = (.*)(id=")(.*)(" rx=) resulting subsitute = $1$2uml_$3$4

so basically I've added uml_ in front of SVG ids

tfrancart commented 1 year ago

Fixed in the online version, not in releases

nikokaoja commented 1 year ago

@tfrancart , no prob! I have made a python wrapper around the latest release which contains script that fixes this issue as a temp solution.