sparrow007 / CarouselRecyclerview

Carousel Recyclerview let's you create carousel layout with the power of recyclerview by creating custom layout manager.
Apache License 2.0
640 stars 79 forks source link

Added alternative for ImageReflectionView with enhanced ReflectionVie… #4

Closed snehilrx closed 3 years ago

snehilrx commented 3 years ago

Implemented a custom linear layout to show reflection of the view contained in it. Feature 👍🏾 10x faster load time than ReflectionImageView Matches the view draw in real time.

sparrow007 commented 3 years ago

@snehilrx Thank you for the pull request but before merge into master please add the package name at the top of the file because if that's not added it keeps generating the error of inflation.

snehilrx commented 3 years ago

@sparrow007 I had fixed all the issue as mentioned by you and also the issues that I had found.

Here is a sample usage

<?xml version="1.0" encoding="utf-8"?>
<com.jackandphantom.carouselrecyclerview.view.ReflectionViewContainer
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    xmlns:android="http://schemas.android.com/apk/res/android"
    app:reflect_relativeDepth="0.5"
    app:reflect_gap="0dp"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    >
    <ImageView
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:src="@drawable/guypro"
        android:scaleType="fitXY"
        android:id="@+id/image" />
</com.jackandphantom.carouselrecyclerview.view.ReflectionViewContainer>

Sample Screen

sparrow007 commented 3 years ago

Yeah I see and I love what you do (awesome work man), but if you see your files changes currently which have some error because of different commits (as I mentioned above) so I can't merge it would you please create another pull with all new changes so that it will very easy for me to merge.

snehilrx commented 3 years ago

Going to sleep. Goodnight. I will clarify things tomorrow.

sparrow007 commented 3 years ago

Yeah, no problem :)

snehilrx commented 3 years ago

Sorry for the delayed fix, I was busy with some work. I think it should work now.

sparrow007 commented 3 years ago

No problem, thanks i am reviewing the codes now :)

sparrow007 commented 3 years ago

LGTM