Add new type of alert — Loading Alert

[mlouli]

If you think it's a bad idea to add a loading option, then let's discuss it, maybe you should simply open some of the SPAlert.swift API so anyone using your project can subclass and add things easily.

Also, I noticed that when dark mode is enabled + multitasking on iPad, the blurred background is a little bit weird but I didn't find a solution yet.

Last but not least, why you prefered going with some frame calculation instead of using the auto-layout magic?

[ivanvorobei]

@mlouli thanks for PR! I fast check code and see many interesting changes. Let me full understand it and after merge.

About

dark mode is enabled + multitasking on iPad

You can show video or screenshoot?

[mlouli]

Take your time for the PR, I am open for discussions if needed.

For dark mode issue when multitasking on iPad, I will try adding today a screenshot or sth.

Take care

[mlouli]

RPReplay_Final1585656193.MP4.zip

I compressed the recording, don't hesitate to tell me if you prefer another format then ".zip"

There are weird lines behind the alert when multitasking as you can see in the screen-recording, I also tried with several types of alert, so it's not specific to one alert

[ivanvorobei]

Thanks for video! But I not see any problem, you can explain more?

[mlouli]

Yeah, I agree that it's hard to see 😅.

I attached a screenshot, and I suggest replaying the record I sent you and try to focus plz on the background of the alert, you will notice some strange stains only when multitasking 🧐

Also if you can try to build the Example Project on an iPad (real or simulator), maybe you will see it easily 🤷‍♂️

[ivanvorobei]

@mlouli catch! I think it blur render problem

[ivanvorobei]

@mlouli good day, I return and check code. Thanks for clean!

So, about loading. I sew two cases, which need attention: We need use default struct with presets, lie this SPAlert.presentLoading(message: "Loading...", preset: .loading)

And I think all users want close loading alert not with timeout. They prefer hide it by event. By this case, when you have time, you can do you work as extension of current system?

If you need access to some internal properties or any other - please, write me. Also I available in telegram @ivanvorobei

If you don't want do it, also please write me. I using your code add it as extension. For now I close PR, but I think your idea with loading is great. And wait info from you.

[productdevbook]

new version how to used loading ?