search

sparrowcode / AlertKit

Native alert from Apple Music & Feedback. Contains Done, Heart & Message and other presets.
https://sparrowcode.io/frameworks
MIT License
2.3k stars 130 forks source link

Some updates #54

Closed HassanTaleb90 closed 8 months ago

ivanvorobei commented 11 months ago

Thanks for your PR! I ready to merge, but need remove optional image for custom. If need only text just skip passing alert icon model.

HassanTaleb90 commented 11 months ago

The optional is just for safety's sake, to prevent the app from crashing if a non-existent image is passed, as when using a UIImageView image.

ivanvorobei commented 11 months ago

It's good idea but developer can use if let condition for safe unwrap. Can you remove it from PR?

HassanTaleb90 commented 11 months ago

Updated

ivanvorobei commented 9 months ago

I see you changed size of old version, why?

HassanTaleb90 commented 9 months ago

I see you changed size of old version, why?

It seems to me that the old size is too small. The title breaks to a new line for just a few words. Example: "Unable to Add Documentation" ->

Unable to Add Documentation

ivanvorobei commented 9 months ago

I see. I follow native one of apple examples, but I see you want customise it. I will think how better solve it.

For now proposing drop changes of height and left rest changes with top/bottom and optional changes.