search

sparrowcode / PermissionsKit

Universal API for request permission and get its statuses.
https://x.com/sparrowcode_ios
MIT License
5.64k stars 462 forks source link

didHide() is called everytime #102

Closed goreste closed 5 years ago

goreste commented 5 years ago

Hi,

I noticed that the method didHide() of the SPPermissionDialogDelegate is being called when i tap on ALLOW button of a permission and the request popup of Apple appear.

This happens if i set the computed var dragEnabled to false.

Shouldn't be called only when the user tap on the close button?

Thanks, Paolo

ivanvorobei commented 5 years ago

@goreste this function is called whenever the controller is closed. If all permissions are received, the controller will close automatically and call the method didHide().

When you tap ALLOW button, called method didAllow() or didDenied()

If you have not found a mistake in your code and are sure that the problem is on my side, please make a simple project with an example of the problem and place the link here. Thank!

goreste commented 5 years ago

Hi, thanks for the response. The bug was inside the 3.0.2 version. Now that i upgraded the pod i'ts fixed :)

Thanks again and compliments for the pod!

ivanvorobei commented 5 years ago

Thanks!)