search

sparrowcode / PermissionsKit

Universal API for request permission and get its statuses.
https://x.com/sparrowcode_ios
MIT License
5.64k stars 462 forks source link

Purpose of Checking SPPERMISSION_FLAGS? #188

Closed muhasturk closed 4 years ago

muhasturk commented 4 years ago

What is the purpose of checking every SPPERMISSION_FLAGS in xcconfig and throw fatalError if there is no flag defined. Just use it without compiler flags.

I already have my custom xcconfig file and I dont want to use any third party framework's xcconfig file.

What should we do?

muhasturk commented 4 years ago

By the way I am using SPM for installation for SPPermissions. My workspace using own xcconfig file. So I could not select "SPPermissionsConfiguration.xcconfig" in project settings.

muhasturk commented 4 years ago

Integration with SPM is causing crash. Please do not check compiler flags.

ivanvorobei commented 4 years ago

Please, see this #156

muhasturk commented 4 years ago

I see that issue but there is no answer for my question. Is there any reason to check compiler flags? You can abort checking compiler flag for permission types.

ivanvorobei commented 4 years ago

You right, now no answer to your questions. It problem not solved now.

Yes, need check compiler flags for permissions, it request by apple usage only required permissions in app. Without flags you catch full import of all permissions. And reject app after.