sparrowcode / PermissionsKit

Universal API for request permission and get its statuses.
https://x.com/sparrowcode_ios
MIT License
5.64k stars 462 forks source link

[SUGGESTION] - Carthage #32

Closed maclacerda closed 5 years ago

maclacerda commented 7 years ago

Hello,

It's possible add the Carthage support on your Library ?

Thanks

jojo91 commented 7 years ago

+1

Droppix commented 6 years ago

+1

ivanvorobei commented 5 years ago

Friends, soon! I am realize new version, and will add Carthage )

kirillrybin commented 5 years ago

+1

sverin commented 5 years ago

@IvanVorobei Any chance to release the version with carthage support?

ivanvorobei commented 5 years ago

@sverin, I tried to figure out how to add support, but I did not succeed. I hope that someone will be able to suggest how to do it and I will release a version

sverin commented 5 years ago

@IvanVorobei

To add support for Carthage for your existing library you need to share the scheme of your project. To do that you have to:

Open the workspace. Go to Product > Scheme > Manage Schemes. Select the Shared checkbox for your scheme

Test if the scheme builds successfully by running carthage build --no-skip-current.

You also need to commit the SPPermission.xcodeproj file. All files in the project should be commited. If the build still fails, uncheck the the shared scheme and check it again.

ivanvorobei commented 5 years ago

@sverin, thanks! I think I understood... The map file implies that my library will be part of the scheme. Is there an opportunity for the map file to specify only the package with the source files? No in project SPPermission all resources files place in /source folder

toftof commented 5 years ago

hi, hope you you can release Carthage support soon. Love this framework

ivanvorobei commented 5 years ago

Good day friends!

Now I am work about ‘Carthage’! 🔥 But it first publish and I am need testing period... please, after publish, testing it.

Thanks, dear friends!

ivanvorobei commented 5 years ago

Friends, I am added support Carthage. You can test it now. If you find any bugs, please, create new issue. Thanks!