search

sparrowcode / PermissionsKit

Universal API for request permission and get its statuses.
https://x.com/sparrowcode_ios
MIT License
5.64k stars 462 forks source link

Close button option not working and swipe only works vertically #64

Closed emaddoma closed 5 years ago

emaddoma commented 5 years ago

Just updated to 2.1.1 and the new close button option doesn't seem to work. Also, it's impossible to dismiss the modal by swiping horizontally.

ivanvorobei commented 5 years ago

Good day!

1) I understood correctly, you want to be able to turn off the brush of the dial-up window?

2) After clicking on the close button, nothing happens? Or an error occurs?

emaddoma commented 5 years ago
  1. You must "Swipe" vertically to dismiss the modal. Swiping horizontally does not dismiss the modal.
  2. The close button does not appear when showCloseButton is overridden to true on SPPermissionDialogDataSource

simulator screen shot - iphone 6 - 2018-11-19 at 20 37 13

ivanvorobei commented 5 years ago

Now I understand.

1) Horizontal swipe will not be supported. I believe that you need to leave only vertical

2) I just installed the latest version 2.1.1 and everything works correctly, by pressing the button, the controller closes. Check or you specified a DataSource object. If not this simple mistake - you need to understand why it does not work.

You can download an example from the repository to make sure everything works.