search

sparrowwallet / sparrow

Desktop Bitcoin Wallet focused on security and privacy. Free and open source.
https://sparrowwallet.com/
Apache License 2.0
1.36k stars 192 forks source link

.desktop should set Single Window #1436

Closed BenWestgate closed 4 months ago

BenWestgate commented 5 months ago

Hello Sparrow

I noticed the .desktop file included in the linux packages displays "New Window" in the context menu of right clicking on the Icon in Gnome but Sparrow is a single window application so this is wrong and does nothing useful if clicked.

Current Incorrect Behavior: image

image

This can be prevented by adding this to key to the .desktop file:

SingleMainWindow=true

Desired Behavior after adding the above: image

image

craigraw commented 5 months ago

Thanks for suggesting this.

There is actually one case where this function does do something - when running Sparrow with another network configuration, it will open a window in mainnet. I assume this is true for any configuration that differs from the default. That said, I discovered this purely by accident, and I doubt it is obvious or particularly useful, so I am still leaning towards implementing your suggestion.

BenWestgate commented 5 months ago

Thanks for suggesting this.

There is actually one case where this function does do something - when running Sparrow with another network configuration, it will open a window in mainnet. I assume this is true for any configuration that differs from the default. That said, I discovered this purely by accident, and I doubt it is obvious or particularly useful, so I am still leaning towards implementing your suggestion.

Well it should be more specific than "New Window": "New Mainnet Window" or "Open Mainnet Window" would be better titles. This isn't like calculator where each window is identical.

I can make that a drop down menu. So left click is mainnet and right click presents all network options, not already open. (Max single window per network)

But I have to imagine 90%+ of people testing non-mainnet are not launching with the app menu. Especially since it has never presented those options. And I also think exposing these to everyone when 90%+ only need mainnet presents too many choices, too visibly. So this fancy solution may be a waste of time. What do you think?

craigraw commented 5 months ago

I think it's probably best to just remove it altogether as you originally proposed :)