search

sparrowwallet / sparrow

Desktop Bitcoin Wallet focused on security and privacy. Free and open source.
https://sparrowwallet.com/
Apache License 2.0
1.35k stars 190 forks source link

Lock information on Keystore Tab (Watch Only Wallet) #1484

Closed pvig0q1s closed 2 months ago

pvig0q1s commented 2 months ago

It is possible to edit information when Keystore is of type 'Watch Only Wallet'.

Master fingerprint, Derivation, tpub / Vpub Fields are editable.

Like with other keystore types, the fields should be in locked state once the wallet is saved. Even though there is a fail-save (popup "Change Wallet Addresses?"), users should use the 'Replace' Button instead.

craigraw commented 2 months ago

It is possible to edit information when Keystore is of type 'Watch Only Wallet'.

Yes. But the edited information is only used when the wallet is saved with the Apply button. If the user wants to go back to the original before saving, the Revert button is available.

Like with other keystore types, the fields should be in locked state once the wallet is saved. Even though there is a fail-save (popup "Change Wallet Addresses?"), users should use the 'Replace' Button instead.

There is a significant difference here from the other keystore types - the fields for a watch only wallet are only editable by changing these fields. So requiring the user to use the Replace button not only seems less intuitive to me, but would require the user to start from scratch rather than just editing one of the existing fields.

pvig0q1s commented 2 months ago

I have not thought about this, good point.

Thanks (also, for your work in general. I wish U all the best! :bird:)