sparrowwallet / sparrow

Desktop Bitcoin Wallet focused on security and privacy. Free and open source.
https://sparrowwallet.com/
Apache License 2.0
1.36k stars 192 forks source link

Custom Policy Type #1515

Closed anurag-l1nt closed 1 month ago

anurag-l1nt commented 1 month ago

I’ve noticed that in the settings.fxml file, the "CUSTOM" option for Policy Type has been commented out since 2020, although looking at other parts of the code, it seems that there is some support implemented for it.

https://github.com/sparrowwallet/sparrow/blob/233addc1b7a8c20efaede39919bf91397a1c0223/src/main/resources/com/sparrowwallet/sparrow/wallet/settings.fxml#L35-L41

Why was it deactivated?

I ask because I would like to "play" with this and implement some custom policy type, perhaps a time-locked multisig, and I’d like to know if the option was disabled because there’s some capability that’s not supported or if it was just for security reasons, to prevent users from putting their funds at risk by using policy types they’re unfamiliar with.

I think it could be interesting to have a few other predefined Policy Types that could be useful for users, implementing more complex contracts like spending with multisig at any time or with a single signature after a set time, for example.

Thank you very much.

craigraw commented 1 month ago

It was never implemented. Custom policy types are not currently supported, and there are no immediate plans to implement them.