sparrowwallet / sparrow

Desktop Bitcoin Wallet focused on security and privacy. Free and open source.
https://sparrowwallet.com/
Apache License 2.0
1.36k stars 192 forks source link

sparrow wallet don't save transaction labels #1523

Closed onlineapps-cloud closed 4 days ago

onlineapps-cloud commented 1 month ago

hi, why sparrow wallet don't save all labels?, some label are saved, but many labels are not saved, but label is required, i cannot made transaction without label. image

craigraw commented 1 month ago

How are you broadcasting the transactions? Labels can only be saved when the transaction is created on Sparrow, broadcasted and then received in the same session.

onlineapps-cloud commented 1 month ago

i create transaction like this: image then i click, finalize transaction by signing image then i click, sign button image then i enter password, and click broadcast transaction.

onlineapps-cloud commented 1 month ago

and then received in the same session.

what this mean? what i need to receive in same session?

craigraw commented 1 month ago

what this mean? what i need to receive in same session?

As in, you broadcasted and received the transaction without closing Sparrow. In this case, the label you set when creating the transaction should always be applied.

onlineapps-cloud commented 1 month ago

very strange, why this label don't save every time without another rules? like in feather wallet or other wallet, i just put label, and done, all working without receiving something back, and wait to be receive something, very strange and usefulness actions, i need to wait and don't close client.

craigraw commented 1 month ago

i need to wait and don't close client

Waiting in this case is just a few seconds (if not, you have a server issue). Without this wait, you don't know if the transaction has been successfully broadcast (as in, whether it is in the P2P network). Broadcasting can fail for a variety of reasons. A wallet is doing a poor job if it shows a transaction as successfully broadcast, when in fact it is not.

onlineapps-cloud commented 1 month ago

after made a transaction, i all time let client opened for 3-5 minutes, i don't close immediately client, but my labels are not saved, in rare case labels are saved

craigraw commented 1 month ago

In the cases where it doesn't appear: After you broadcast the transaction, do you receive a notification, and does it appear in the transactions table?

onlineapps-cloud commented 1 month ago

do you receive a notification, and does it appear in the transactions table?

i get unconfirmed transaction in mempool, in right upper corner, you about this notification? another notification sparrow don't give.

and does it appear in the transactions table?

yes, i have new transaction in table, without label

craigraw commented 1 month ago

I can't reproduce this - and I test many, many transactions, all of them have the label applied. Further, no other user is reporting this behaviour. You have already provided screenshots of your steps, which look normal, so I'm not sure what else to suggest other than creating a video of the process indicating the problem. If you do this, ideally use testnet so you don't need to blur anything out.

onlineapps-cloud commented 1 month ago

sorry, i tried to open in testnet i selected testnet3, and what next? i need to open my wallet or create new wallet? because right now i create new wallet, but i cannot made any operations insufficient funds image

craigraw commented 4 weeks ago

Rather use testnet4, testnet3 is deprecated. Create a new wallet. You can get testnet coins from (for example) https://coinfaucet.eu/en/btc-testnet4/.

onlineapps-cloud commented 4 days ago

As in, you broadcasted and received the transaction without closing Sparrow.

hi, i found problem, i don't need to close transaction tab! not sparrow window, just tab where i made transaction, because main tab with wallet is always opened, but if i close transaction tab after made a transaction, i lose labels

craigraw commented 4 days ago

Glad to hear. You should be able to close the transaction tab after the broadcasted transaction has been received into the wallet. Closing this off.