search

sparrowwallet / sparrow

Desktop Bitcoin Wallet focused on security and privacy. Free and open source.
https://sparrowwallet.com/
Apache License 2.0
1.36k stars 192 forks source link

Feature request: monospace font for dates and numbers in transactions overview. #1524

Closed rdouma closed 4 weeks ago

rdouma commented 1 month ago

In my opinion the transactions overview would look much better if dates are neatly aligned as well as the decimal point of the value and the balance. It'll probably look better if the transactions column also uses that same monospace font; I would prefer that over all columns not having a monospace font.

craigraw commented 1 month ago

I assume you are using macOS?

This actually looks like a regression, since Sparrow is using Helvetica Neue Regular to display values which is used in macOS Numbers for it's monospaced display of digits. It appears that in upgrading to JavaFX 22, this monospaced property was lost. I'll need to investigate if it's possible to get it back.

rdouma commented 1 month ago

Indeed, I use MacOS, apologies for not adding that to the original issue. Here are some screenshots that illustrate what I mean.

2024-10-21_09-40-25 2024-10-21_09-40-09 2024-10-21_09-39-17

craigraw commented 1 month ago

It did turn out to be a regression introduced in the recent upgrade to JavaFX 22 in Sparrow 2.0.0. I'm working on a fix using the font Liberation Sans which provides monospaced characters for digits, but looks sufficiently similar to the system font to not be visually jarring:

Screenshot 2024-10-22 at 19 54 35
craigraw commented 4 weeks ago

Regression fixed in d0bf55de.

rdouma commented 4 weeks ago

Thanks! 🙏 Looking forward to the new release.