sparrowwallet / sparrow

Desktop Bitcoin Wallet focused on security and privacy. Free and open source.
https://sparrowwallet.com/
Apache License 2.0
1.33k stars 188 forks source link

Scanning 3of5 QR code with CoboVault and Specter-DIY HWWs fails. #60

Closed dermichal closed 3 years ago

dermichal commented 3 years ago

Succesfully exported a 3 of 5 Multisig-Wallet from Specter-Desktop into Sparrow.

When trying to sign a transaction with CoboVault the following error appears: IMG_2374

Scanning with Specter-DIY HWW also fails: IMG_2375

Both devices are able to read 3of5 QR from Specter-Desktop and BlueWallet.

Thanks

Firmware: Cobo: V2.3.1-BTC_Only Specter-DIY: v1.4.5

craigraw commented 3 years ago

On Sparrow, did you enable the legacy mode (button at the bottom of the QR display dialog)?

dermichal commented 3 years ago

Do you mean the type of Sighash? Tried all of them. Unfortunately it makes no difference.

craigraw commented 3 years ago

No - there is a button at the bottom of the dialog where the animated QR is displayed.

dermichal commented 3 years ago

No button present in my QR dialog.

Screenshot 2021-02-07 at 18 51 41

Running Sparrow 1.0.0

craigraw commented 3 years ago

Ok - because this was an import, the keystore for the Cobo Vault was imported with the essential public key details, but not the device type. Currently, Sparrow only displays the legacy mode button when a Cobo device type is part of the wallet. Possibly this should change!

In the meantime, the simplest way to solve this is to replace that keystore in your wallet settings, reimporting the Cobo. To do this, go to the Settings tab, and select the keystore that represents your Cobo (or each of them in turn if there is more than one). Click 'Replace', select Airgapped in the dialog that pops up, and reimport the Cobo details by selecting the Scan button on the Cobo Vault type, and presenting the QR on the device using the Multisig Wallet > Show/Export XPUB feature.

The button should then be present in the QR display dialog.

craigraw commented 3 years ago

Added the legacy QR display button for imported wallets in 0097a1e.