search

sparrowwallet / sparrow

Desktop Bitcoin Wallet focused on security and privacy. Free and open source.
https://sparrowwallet.com/
Apache License 2.0
1.36k stars 192 forks source link

[Feature Request] Disabling the broadcasting button on account level #859

Open feelancer21 opened 1 year ago

feelancer21 commented 1 year ago

Hello, I am looking for an advanced setting to disable the broadcoasting button on account level.

Why? If you are using Sparrow for external funding of lightning channels you don't have to broadcast the signed transaction by our own. You have to transmit the tx to lnd. If you accidentally broadcast the tx there is a risk of loosing funds. Of course you could disconnect Sparrow from your server but this is a bad workaround, because sometimes you need the connection for loading the history.

Imho the best way to prevent accidental broadcasts is to disable the button for the funding account.

craigraw commented 1 year ago

This is an odd feature, in the sense that it doesn't fit in well with any current UI. Is there a way this kind of transaction might be detected so a warning can be displayed instead?

feelancer21 commented 1 year ago

I don't think it is possible to detect such transaction because there are normal spendings to other bitcoin addresses. I am using a specific account for the external fundings to prevent mixing with my other utxos. Hence the only way to detect such a tx is, when the inputs are from a specific account.

RocketNodeLN commented 9 months ago

+1 for a No Broadcast option or even an additional dialog box after clicking the broadcast button.

feelancer21 commented 8 months ago

Here is someone who "lost" 1 BTC with a channel opening

https://stacker.news/items/436720