search

sparsemat / sprs

sparse linear algebra library for rust
Apache License 2.0
396 stars 47 forks source link

Generalize ndarray version support #142

Closed pmarks closed 5 years ago

pmarks commented 5 years ago

I've manually run cargo test with all ndarray versions that fall in the range: ndarray = ">=0.11, <0.13.0" -- they all compile and pass test. Could we generalize the ndarray version support to cover this?

A few people I work with have updated ndarray and gotten 'trait not implemented' errors because the top-level ndarray version doesn't match the sprs version.

(edited based on @rth's suggestion -- we should allow all of 0.12.*)

rth commented 5 years ago

Could we generalize the ndarray version support to cover this?

+1 -- I had the same issue recently.

rth commented 5 years ago

Maybe, ndarray = ">=0.11, <0.13.0" assuming ndarray doesn't break semver for 0.12?

Also running tests in travis CI for the oldest and the newest ndarray version might make sense.