sparsemat / sprs

sparse linear algebra library for rust
Apache License 2.0
381 stars 45 forks source link

use same version of dependencies #248

Closed mulimoen closed 3 years ago

mulimoen commented 3 years ago

This ensures all dependencies are the same version

vbarrielle commented 3 years ago

Good idea, with the upcoming 0.10 it's the good moment to introduce changes in dependencies versions. Looks like there's a rusftmt issue though.

vbarrielle commented 3 years ago

Looking at the failure, it's an issue I've encountered for #245, and it's fixed there. It's caused by a change in rustmft with the latest rust release. Re-running the tests should work.

vbarrielle commented 3 years ago

No I'm wrong, it needs to be rebased. Alternatively, I can merge it like this, and the merge result should pass the rustfmt test.

mulimoen commented 3 years ago

I've rebased on master now

vbarrielle commented 3 years ago

Perfect, thanks!