search

sparsemat / sprs

sparse linear algebra library for rust
Apache License 2.0
381 stars 45 forks source link

More ergonomic slicing #252

Closed vbarrielle closed 3 years ago

vbarrielle commented 3 years ago

As mentionned in #250, the slicing of middle matrices along the outer dimension is quite cumbersome to use, which is particularly visible in the matrix product implementation in smmp.rs. This PR tries to propose a more ergonomic API.

vbarrielle commented 3 years ago

I'm leaving this as-is for now, as I'd like to take some time to reflect on this new API. @mulimoen, if you want, I'd very much appreciate your feedback on these changes.

vbarrielle commented 3 years ago

@mulimoen the latest changes should address all your remarks. I've also added the policy on reborrowing on the guidelines to have a point of reference

mulimoen commented 3 years ago

Excellent work @vbarrielle!