search

sparsemat / sprs

sparse linear algebra library for rust
Apache License 2.0
394 stars 46 forks source link

minor code fix to upgrade pyo3 to 0.16.5 #304

Closed chetmurthy closed 2 years ago

chetmurthy commented 2 years ago

I'm not sure if this is done correctly, but it seems to work (passes cargo test, cargo bench).

It seems the way a method gets called has changed.

chetmurthy commented 2 years ago

Hmmm .... looks like pyo3 0.16.5 doesn't build in the CI. I don't know what to do to fix this.

mulimoen commented 2 years ago

Maybe you can bump ubuntu-18.04 to ubuntu-20.04 in the CI definition?

chetmurthy commented 2 years ago

Will do (and thanks for the pointer!) I haven't worked with CI configs at all, so new to all this. Thank you again!

mulimoen commented 2 years ago

Thanks @chetmurthy for this bump!