search

sparsemat / sprs

sparse linear algebra library for rust
Apache License 2.0
394 stars 46 forks source link

Include license files in published crates #331

Closed ankane closed 1 year ago

ankane commented 1 year ago

Hey, thanks for this library!

This PR symlinks the license files so they're included in the published crates (like with sprs 0.11.0).

mulimoen commented 1 year ago

Thanks for the PR. I would think the licenses are fairly well known and not necessary to include. Is there a benefit in adding these files to the published blobs?

ankane commented 1 year ago

Hi @mulimoen, both licenses mention including it with copies of the software, and it's nice for things like cargo vendor (https://github.com/microsoft/windows-rs/issues/1587#issuecomment-1063010186).

mulimoen commented 1 year ago

I see. Thanks for the explanation and the PR!

ankane commented 1 year ago

Great, thanks!