spartacus04 / jext-reborn

Level up your server with custom music discs - "Just like vanilla jukebox, but better!". I mantain this in my free time.
https://spartacus04.github.io/jext-reborn/
Other
34 stars 7 forks source link

[Bug]: Other players cannot hear the music #89

Closed oogsmydudes closed 1 year ago

oogsmydudes commented 1 year ago

Describe the bug

I can hear the audio from the disc (both with the playmusic command and with the item disc) while other players cannot hear it. The resource pack is on the server and is required.

Steps to reproduce

  1. Add the songs to the built-in tool
  2. Set the audio on Mono
  3. add the JSON file to the plugin folder
  4. Add the texture pack to the server config

Expected behaviour

The expected behavior is that everyone in the server should be able to hear it.

Logs

No response

Server Version

1.19.3

Server Type

Paper

Java Version

1.19.3

Discs.json

[
  {
    "title": "Koyaanisqatsi",
    "author": "Philip Glass",
    "duration": 210,
    "disc-namespace": "music_disc.koyaanisqatsiphilipglasszero",
    "model-data": 1,
    "creeper-drop": true,
    "lores": [
      "\"Life Out of Balance\""
    ],
    "loot-tables": [
      "chests/ancient_city",
      "chests/ancient_city_ice_box",
      "chests/simple_dungeon",
      "chests/stronghold_corridor",
      "chests/stronghold_crossing",
      "chests/woodland_mansion"
    ],
    "fragment-loot-tables": []
  },
  {
    "title": "Organic",
    "author": "Philip Glass",
    "duration": 299,
    "disc-namespace": "music_disc.organicphilipglassone",
    "model-data": 2,
    "creeper-drop": true,
    "lores": [
      "\"A State of Life that Calls for Another Way of Living\""
    ],
    "loot-tables": [
      "chests/ancient_city",
      "chests/ancient_city_ice_box",
      "chests/simple_dungeon",
      "chests/stronghold_corridor",
      "chests/stronghold_crossing",
      "chests/woodland_mansion"
    ],
    "fragment-loot-tables": []
  },
  {
    "title": "Prophecies",
    "author": "Philip Glass",
    "duration": 492,
    "disc-namespace": "music_disc.propheciesphilipglasstwo",
    "model-data": 3,
    "creeper-drop": true,
    "lores": [
      "\"A container of ashes might one day be thrown from the sky, which could burn the land and boil the oceans.\""
    ],
    "loot-tables": [
      "chests/ancient_city",
      "chests/ancient_city_ice_box",
      "chests/simple_dungeon",
      "chests/stronghold_corridor",
      "chests/stronghold_crossing",
      "chests/woodland_mansion"
    ],
    "fragment-loot-tables": []
  },
  {
    "title": "The Seed",
    "author": "Ryuichi Sakamoto",
    "duration": 65,
    "disc-namespace": "music_disc.theseedryuichisakamotothree",
    "model-data": 4,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [
      "chests/igloo_chest",
      "chests/simple_dungeon",
      "chests/woodland_mansion",
      "chests/ancient_city",
      "chests/ancient_city_ice_box"
    ],
    "fragment-loot-tables": []
  },
  {
    "title": "Merry Christmas Mr. Lawrence",
    "author": "Ryuichi Sakamoto",
    "duration": 277,
    "disc-namespace": "music_disc.merrychristmasmrlawrenceryuichisakamotofour",
    "model-data": 5,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [
      "chests/woodland_mansion",
      "chests/ancient_city",
      "chests/ancient_city_ice_box",
      "chests/simple_dungeon"
    ],
    "fragment-loot-tables": [
      "chests/igloo_chest",
      "chests/simple_dungeon",
      "chests/woodland_mansion"
    ]
  },
  {
    "title": "Living Room",
    "author": "Kensuke Ushio",
    "duration": 163,
    "disc-namespace": "music_disc.livingroomkensukeushiofive",
    "model-data": 6,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [
      "chests/woodland_mansion",
      "chests/abandoned_mineshaft",
      "chests/simple_dungeon",
      "chests/ancient_city",
      "chests/ancient_city_ice_box"
    ],
    "fragment-loot-tables": []
  },
  {
    "title": "Three Sonic Spaces I",
    "author": "Laurie Spiegel",
    "duration": 96,
    "disc-namespace": "music_disc.threesonicspacesilauriespiegelsix",
    "model-data": 7,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [
      "chests/simple_dungeon",
      "chests/ancient_city",
      "chests/ancient_city_ice_box",
      "chests/woodland_mansion"
    ],
    "fragment-loot-tables": []
  },
  {
    "title": "Weightlesss",
    "author": "Marconi Union",
    "duration": 489,
    "disc-namespace": "music_disc.weightlesssmarconiunionseven",
    "model-data": 8,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [
      "chests/ancient_city",
      "chests/ancient_city_ice_box",
      "chests/simple_dungeon",
      "chests/woodland_mansion"
    ],
    "fragment-loot-tables": []
  },
  {
    "title": "Shuniji",
    "author": "C418",
    "duration": 245,
    "disc-namespace": "music_disc.shunijicfouroneeighteight",
    "model-data": 9,
    "creeper-drop": true,
    "lores": [],
    "loot-tables": [
      "chests/ancient_city",
      "chests/ancient_city_ice_box",
      "chests/simple_dungeon",
      "chests/woodland_mansion"
    ],
    "fragment-loot-tables": []
  }
]

Resource pack

https://www.dropbox.com/s/i14ly22wa8lv9f0/server_music.zip?dl=0

This issue is unique

spartacus04 commented 1 year ago

Hello, Thanks for the bug report. How far were the players from the source of the audio?

oogsmydudes commented 1 year ago

Hello! The players and I were within 2 blocks distance from the source (jukebox).

spartacus04 commented 1 year ago

Maybe it's a stupid question, but perhaps the other players had the audio disabled for the records in the audio settings?

If not it's probably a client issue. Were there any particular differences between your setup and the players setup? (mods used, OS, whatever you think could be important)

oogsmydudes commented 1 year ago

Ah no its not a dumb question as I asked that to myself. Unfortunately, the players could hear the default discs.

Regarding the client differences, I use fabric mods on the windows and I could hear it. However I also tested it on a spare mac running lunar client 1.19.3, which also worked. I do plan to test with even more players as well if this problem continues.

Thank you for your time as always!

spartacus04 commented 1 year ago

Could you try perhaps testing with a vanilla enviroment?

oogsmydudes commented 1 year ago

I just tested now with both a windows and a mac with vanilla and it still works fine for me. Im not sure if its whether something happened with implementing it to the server but that hypothetically shouldn't be the problem as it works fine on both devices with no additional resource pack.

github-actions[bot] commented 1 year ago

Stale issue message